[PATCH] D155638: [llvm-reduce] Reduce function calling convention

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 22:43:54 PDT 2023


dblaikie added a comment.

> So the concern here is that if a target doesn't implement it, then it's likely that we'll get a false positive interesting test when run against something like ! llc?

Personally, I don't think this is a use case worth optimizing for. A match that open ended is bound to trip over other issues - reduce to the wrong crasher, etc. Anything vaguely precise enough to be useful probably isn't going to get tripped up by an attempt to use a calling convention incompatible with the target, I'd have thought?

What's the failure look like when you use a cc incompatible with the target? Does it fail in IR parsing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155638/new/

https://reviews.llvm.org/D155638



More information about the llvm-commits mailing list