[PATCH] D155638: [llvm-reduce] Reduce function calling convention

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 11:14:17 PDT 2023


arsenm added a comment.

In D155638#4531620 <https://reviews.llvm.org/D155638#4531620>, @nikic wrote:

> So the concern here is that if a target doesn't implement it, then it's likely that we'll get a false positive interesting test when run against something like `! llc`? I think for that particular case (CCC not supported) it would be fine to opt-out the relevant calling convention.

Opt out target stuff has been a constant source of pain in llvm. Opt in is a much more manageable system. I don’t see a practical plus to handling anything other than the handful of common CCs (fast, cold, tail)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155638/new/

https://reviews.llvm.org/D155638



More information about the llvm-commits mailing list