[PATCH] D159513: [Bolt] fix a relocation bug for R_AARCH64_CALL26

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 07:14:33 PDT 2023


yota9 added a comment.

One more thing. It seems to be without force-patch the encodeValueAArch64 still would be called, but since functions would be moved to the new text there won't be negative address problem. I don't think there is a better way then using force-funcs so it would fail to patch entries & functions would stay on its current place, but please:

1. Please write the reason of using force-funcs option in the test, because after some time even I won't remember what I wrote above :)
2. Please add checks on llvm-bolt output that func1 and func2 were failed to patch and won't be optimised, since otherwise the test might pass, but the problem won't be checked.

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159513/new/

https://reviews.llvm.org/D159513



More information about the llvm-commits mailing list