[PATCH] D159513: [Bolt] fix a relocation bug for R_AARCH64_CALL26

Sinan Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 04:34:30 PDT 2023


sinan added a comment.

In D159513#4645837 <https://reviews.llvm.org/D159513#4645837>, @Kepontry wrote:

> Yes, you are absolutely right. This is my mistake, I didn't consider the sign bit when performing the right shift.
>
> Thank you for your correction; I'm just getting started in this field, and I'll improve the quality of the patches I submit in the future.
>
> Let's wait for the opinion from the Meta team.

Hi @Kepontry

Take it easy, I made more foolish mistakes when I just started. Keep going and good luck :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159513/new/

https://reviews.llvm.org/D159513



More information about the llvm-commits mailing list