[PATCH] D158185: [DebugInfo] Process single-location debug values in variadic form when producing DWARF

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D158185#4645353 <https://reviews.llvm.org/D158185#4645353>, @fdeazeve wrote:

> Hi @StephenTozer, could you elaborate on what these failures are? I am concerned because, ever since D133926 <https://reviews.llvm.org/D133926>  was merged, there are some methods that were left with an incorrect implementation, like `startsWithDeref` or `isEntryValue`. It would be nice if we could address those.
> Is the proposed fix here revealing a larger problem that may cause D133926 <https://reviews.llvm.org/D133926> to be rethought?

The failures were crashes caused by some expressions being updated incorrectly; the fix I'm uploading is just for this patch, making it a bit more defensive by changing getSingleLocationExpressionElements to actually check whether the expression is variadic, and return an optional, either the single-loc expression or std::nullopt if the expression isn't variadic. I've got the change, I'm running correctness tests again and will upload it shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158185/new/

https://reviews.llvm.org/D158185