[PATCH] D158185: [DebugInfo] Process single-location debug values in variadic form when producing DWARF

Felipe de Azevedo Piovezan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 11:30:32 PDT 2023


fdeazeve added a comment.

> However, I've found the patch triggers some errors when running on the llvm test suite, and the variadic check really isn't that expensive I think, so I'm going to rewrite the patch to do a bit more.

Hi @StephenTozer, could you elaborate on what these failures are? I am concerned because, ever since D133926 <https://reviews.llvm.org/D133926>  was merged, there are some methods that were left with an incorrect implementation, like `startsWithDeref` or `isEntryValue`. It would be nice if we could address those.
Is the proposed fix here revealing a larger problem that may cause D133926 <https://reviews.llvm.org/D133926> to be rethought?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158185/new/

https://reviews.llvm.org/D158185



More information about the llvm-commits mailing list