[PATCH] D157519: [JITLink][AArch32] Tests for ELF::R_ARM_ABS32 and ELF::R_ARM_REL32

Wed Sep 13 06:33:34 PDT 2023

sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.

Thanks for the updates! Can we align the assembly in the test a little more with the (now) existing `ELF_static_thumb_reloc.s`? That may avoid future divergence. Otherwise, this looks good to me.

================
Comment at: llvm/test/ExecutionEngine/JITLink/AArch32/ELF_static_data_reloc.s:13
+
+# Check that Thumb symbol addresses are aligned to 2 bytes and Thumb functions have LSB set
+# CHECK-THM: "abs32": 0x{{[0-9a-f]+[02468ace]}} [Data] Ready
----------------
Function addresses are not in scope for this test, so we can drop the comment as well

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157519/new/

https://reviews.llvm.org/D157519