[llvm] [InlineAsm] wrap ConstraintCode in enum class NFC (PR #66003)
James Y Knight via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 12 12:12:39 PDT 2023
================
@@ -89,9 +89,10 @@ class SelectionDAGISel : public MachineFunctionPass {
/// not match or is not implemented, return true. The resultant operands
/// (which will appear in the machine instruction) should be added to the
/// OutOps vector.
- virtual bool SelectInlineAsmMemoryOperand(const SDValue &Op,
- unsigned ConstraintID,
- std::vector<SDValue> &OutOps) {
+ virtual bool
+ SelectInlineAsmMemoryOperand(const SDValue &Op,
+ const InlineAsm::ConstraintCode ConstraintID,
----------------
jyknight wrote:
Nit: it's weird to mark this parameter itself as const. Not _wrong_ per se, but it's an unusual style, so I think it'd be better to avoid (here and elsewhere).
https://github.com/llvm/llvm-project/pull/66003
More information about the llvm-commits
mailing list