[PATCH] D157437: AMDGPU: Expand remaining system atomic operations

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D157437#4644295 <https://reviews.llvm.org/D157437#4644295>, @yaxunl wrote:

> In D157437#4614101 <https://reviews.llvm.org/D157437#4614101>, @arsenm wrote:
>
>> ping, I think we just need to go with this and add in the new thing later. Also would like clarification on whether add/xchg at system scope are supposed to work
>
> This will cause perf regression for XGMI users. We cannot afford that.

Nobody complained when the last batch were fixed

> Maybe add another option -amdgpu-safe-pcie-atomics to enable the new changes (default off).

Absolutely not


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157437/new/

https://reviews.llvm.org/D157437