[PATCH] D157437: AMDGPU: Expand remaining system atomic operations

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 07:41:59 PDT 2023


yaxunl added a comment.

In D157437#4614101 <https://reviews.llvm.org/D157437#4614101>, @arsenm wrote:

> ping, I think we just need to go with this and add in the new thing later. Also would like clarification on whether add/xchg at system scope are supposed to work

This will cause perf regression for XGMI users. We cannot afford that.

Maybe add another option -amdgpu-safe-pcie-atomics to enable the new changes (default off).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157437/new/

https://reviews.llvm.org/D157437



More information about the llvm-commits mailing list