[PATCH] D159495: [VP] IR expansion for abs/smax/smin/umax/umin

Sun Sep 10 19:04:08 PDT 2023

Miss_Grape marked an inline comment as done.
Miss_Grape added a comment.

In D159495#4642794 <https://reviews.llvm.org/D159495#4642794>, @RKSimon wrote:

> Please make sure you generate your diffs with context `git diff -U9999 HEAD` etc.

done

================
Comment at: llvm/test/CodeGen/X86/expand-vp-int-intrinsics.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avx        | FileCheck %s --check-prefixes=X86
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown                  | FileCheck %s --check-prefixes=SSE
----------------
RKSimon wrote:
> Please can you add this seperately as a pre-commit?
when these patch merge， I will add the test for i686

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159495/new/

https://reviews.llvm.org/D159495