[PATCH] D158141: [AMDGPU] SILowerControlFlow: fix preservation of LiveIntervals

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 10 00:57:38 PDT 2023


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:835-837
+    // Note: we cannot update block layout and preserve live intervals;
+    // hence we must insert a branch.
+    MachineInstr *BranchMI = BuildMI(*FallThrough, FallThrough->end(),
----------------
This doesn't sound right but I guess it will be cleaned up later anyway


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158141/new/

https://reviews.llvm.org/D158141



More information about the llvm-commits mailing list