[llvm] 4085cb3 - Improve the pull-request subcription notification format by adding the description and files statistics (#65828)

[via llvm-commits]

Author: Mehdi Amini
Date: 2023-09-08T22:54:53-07:00
New Revision: 4085cb380d8f95783842c11e1f41a474b0a11ef3

URL: https://github.com/llvm/llvm-project/commit/4085cb380d8f95783842c11e1f41a474b0a11ef3
DIFF: https://github.com/llvm/llvm-project/commit/4085cb380d8f95783842c11e1f41a474b0a11ef3.diff

LOG: Improve the pull-request subcription notification format by adding the description and files statistics (#65828)

Added: 
    

Modified: 
    llvm/utils/git/github-automation.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 6fcd29301230a5..7df20ea8457155 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -65,6 +65,14 @@ def run(self) -> bool:
         return False
 
 
+def human_readable_size(size, decimal_places=2):
+    for unit in ["B", "KiB", "MiB", "GiB", "TiB", "PiB"]:
+        if size < 1024.0 or unit == "PiB":
+            break
+        size /= 1024.0
+    return f"{size:.{decimal_places}f} {unit}"
+
+
 class PRSubscriber:
     @property
     def team_name(self) -> str:
@@ -77,23 +85,62 @@ def __init__(self, token: str, repo: str, pr_number: int, label_name: str):
         self._team_name = "pr-subscribers-{}".format(label_name).lower()
 
     def run(self) -> bool:
-        for team in self.org.get_teams():
-            if self.team_name != team.name.lower():
-                continue
-            try:
-                # GitHub limits comments to 65,536 characters, let's limit our comments to 20,000.
-                patch = requests.get(self.pr.
diff _url).text[0:20000]
-            except:
-                patch = ""
-            comment = (
-                "@llvm/{}".format(team.slug)
-                + "\n\n<details><summary>Changes</summary><pre>\n"
-                + patch
-                + "\n</pre></details>"
-            )
-            self.pr.as_issue().create_comment(comment)
+        patch = None
+        team = self._get_curent_team()
+        if not team:
+            print(f"couldn't find team named {self.team_name}")
+            return False
+
+        # Get statistics for each file
+        
diff _stats = f"{self.pr.changed_files} Files Affected:\n\n"
+        for file in self.pr.get_files():
+            
diff _stats += f"- ({file.status}) {file.filename} ("
+            if file.additions:
+                
diff _stats += f"+{file.additions}"
+            if file.deletions:
+                
diff _stats += f"-{file.deletions}"
+            
diff _stats += ") "
+            if file.status == "renamed":
+                print(f"(from {file.previous_filename})")
+            
diff _stats += "\n"
+        
diff _stats += "\n"
+
+        # Get the 
diff 
+        try:
+            patch = requests.get(self.pr.
diff _url).text
+        except:
+            patch = ""
+        
diff _stats += "\n<pre>\n" + patch
+
+        # GitHub limits comments to 65,536 characters, let's limit the 
diff  to 20kB.
+        DIFF_LIMIT = 20 * 1024
+        patch_link = f"Full 
diff : {self.pr.
diff _url}\n"
+        if len(patch) > DIFF_LIMIT:
+            patch_link = f"\nPatch is {human_readable_size(len(patch))}, truncated to {human_readable_size(DIFF_LIMIT)} below, full version: {self.pr.
diff _url}\n"
+            
diff _stats = 
diff _stats[0:DIFF_LIMIT] + "...\n<truncated>\n"
+        
diff _stats += "</pre>"
+
+        body = self.pr.body
+        comment = (
+            "@llvm/{}".format(team.slug)
+            + "\n\n<details>\n"
+            + f"<summary>Changes</summary>\n\n"
+            + f"{body}\n--\n"
+            + patch_link
+            + "\n"
+            + f"{
diff _stats}\n\n"
+            + "</details>"
+        )
+
+        self.pr.as_issue().create_comment(comment)
         return True
 
+    def _get_curent_team(self) -> Optional[github.Team.Team]:
+        for team in self.org.get_teams():
+            if self.team_name == team.name.lower():
+                return team
+        return None
+
 
 def setup_llvmbot_git(git_dir="."):
     """
@@ -199,7 +246,6 @@ def extract_commit_hash(arg: str):
 
 
 class ReleaseWorkflow:
-
     CHERRY_PICK_FAILED_LABEL = "release:cherry-pick-failed"
 
     """