[llvm] 9818bf2 - Clariy the GitHub PR doc that a "single commit" is only the expected initial state
Mehdi Amini via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 8 16:32:24 PDT 2023
Author: Mehdi Amini
Date: 2023-09-08T16:32:11-07:00
New Revision: 9818bf2619b1213ebf045250dc13562e723e581a
URL: https://github.com/llvm/llvm-project/commit/9818bf2619b1213ebf045250dc13562e723e581a
DIFF: https://github.com/llvm/llvm-project/commit/9818bf2619b1213ebf045250dc13562e723e581a.diff
LOG: Clariy the GitHub PR doc that a "single commit" is only the expected initial state
Review rounds can add more commits, this addresses a post-merge comment.
Added:
Modified:
llvm/docs/GitHub.rst
Removed:
################################################################################
diff --git a/llvm/docs/GitHub.rst b/llvm/docs/GitHub.rst
index 34dda79ed8f6f4..d726c76e7d5f2d 100644
--- a/llvm/docs/GitHub.rst
+++ b/llvm/docs/GitHub.rst
@@ -39,7 +39,8 @@ recommended.
Creating Pull Requests
----------------------
-Keep in mind that each pull request should generally only contain one commit.
+Keep in mind that when creating a pull request, it should generally only contain one
+self-contained commit initially.
This makes it easier for reviewers to understand the introduced changes and
provide feedback. It also helps maintain a clear and organized commit history
for the project. If you have multiple changes you want to introduce, it's
More information about the llvm-commits
mailing list