[PATCH] D159488: [BOLT] Always match stale entry blocks

Sergey Pupyrev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 15:45:22 PDT 2023


spupyrev added a comment.

> Thanks. We recently discussed a case where stale matching was unable to match any block in a function and so function exec count was not set. We thought it's still beneficial to set exec count in this case for function reordering. I assume the entry block match will also make stale matching set function exec count in this scenario?

Once we get into the block-matching code path, the function is guaranteed to be marked as having valid profile, and thus, it will be considered for all optimizations. There are a few exceptions earlier (`canApplyInference()`) which may leave some functions without profile, and this is unchanged by the diff. To address your scenario, we'd need something else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159488/new/

https://reviews.llvm.org/D159488



More information about the llvm-commits mailing list