[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 10:41:18 PDT 2023


mstorsjo added a comment.

In D155579#4641716 <https://reviews.llvm.org/D155579#4641716>, @aganea wrote:

> LGTM, thank you Martin!

Great that it looks good to you now, thanks!

As @aaron.ballman put a negative review in before, on the version with massive performance issues, do you want to have a look on this again now? If everyone are good with it, I’d consider landing it maybe some time next week. And this is clearly way too disruptive to even consider backporting indeed; having it cooking in git main until 18.x seems good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579



More information about the llvm-commits mailing list