[PATCH] D158882: RegisterCoalescer: Don't delete IMPLICIT_DEF if it's live into the same block

Fri Sep 8 09:30:16 PDT 2023

bjope added inline comments.

================
Comment at: llvm/test/CodeGen/X86/pr38795-verifier-error-pr38788.ll:1
-; RUN: llc -mtriple=i386-unknown-linux-gnu -o - -verify-machineinstrs %s | FileCheck %s
-
----------------
arsenm wrote:
> uabelho wrote:
> > I don't know what file this is? It doesn't exist in the repo and it's not added in
> >  https://reviews.llvm.org/D158850
> > 
> > Something you only have in your local repo?
> I just moved this to the main test file 
The file doesn't exist on main. So when trying to apply this patch it fails since there is no file with this name to delete. So there is something weird with "Diff 1" in the differential.

================
Comment at: llvm/test/CodeGen/X86/pr38795.ll:2-3
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39440.
 ; RUN: llc %s -O2 -mtriple=i386-unknown-linux-gnu -o - -verify-machineinstrs=0 | FileCheck %s
 @.str = external dso_local unnamed_addr constant [6 x i8], align 1
----------------
I guess we want to do this now. I.e. enable verify-machineinstrs.

(PR39440 == GH issue 38788)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158882/new/

https://reviews.llvm.org/D158882