[PATCH] D156999: [Inline Spiller] Consider bundles when marking defs as dead

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:764
+        while (It != EndIt && It->isBundledWithPred()) {
+          if (It->isCopy() && It->getOperand(0).isReg() &&
+              It->getOperand(0).getReg() == Reg) {
----------------
Think you need to check isCopyInstr, not the lower level isCopy


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:768
+            LLVM_DEBUG(dbgs() << "All defs dead: " << *It);
+            DeadDefs.push_back(&*It);
+          }
----------------
My point was you should delete the whole bundle at a time, not just prune the copies out of it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156999/new/

https://reviews.llvm.org/D156999