[PATCH] D158291: [PoC][WIP] Add an AArch64 specific pass for loop idiom recognition

[David Sherwood via Phabricator via llvm-commits]

david-arm marked 2 inline comments as done.
david-arm added a comment.

Again, I've only addressed bug fixes in this new update - I'll let @kmclaughlin deal with any other comments once she is back!



================
Comment at: llvm/lib/Target/AArch64/AArch64LoopIdiomRecognize.cpp:295
+             m_Br(m_ICmp(WhilePred, m_Value(LoadA), m_Value(LoadB)),
+                  m_BasicBlock(TrueBB), m_BasicBlock(FoundBB))))
+    return false;
----------------
craig.topper wrote:
> Do we need to check that TrueBB is the header?
Both this and the above comment about WhileBB are excellent spots. I've fixed these now - thanks @craig.topper. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158291/new/

https://reviews.llvm.org/D158291