[PATCH] D152545: [NFC][DebugInfo][RemoveDIs] Provide an iterator-taking split-block method

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 02:00:50 PDT 2023


Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM (with formatting nits)



================
Comment at: llvm/include/llvm/Transforms/Utils/BasicBlockUtils.h:450
+                                       BasicBlock *ThenBlock = nullptr) {
+  return SplitBlockAndInsertIfThen(Cond, SplitBefore->getIterator(), Unreachable, BranchWeights, DT, LI, ThenBlock);
+}
----------------
nit: clang-format


================
Comment at: llvm/include/llvm/Transforms/Utils/BasicBlockUtils.h:489
+                                       BasicBlock *ThenBlock = nullptr) {
+  return  SplitBlockAndInsertIfThen(Cond, SplitBefore->getIterator(), Unreachable, BranchWeights, DTU, LI, ThenBlock);
+}
----------------
nit: clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152545/new/

https://reviews.llvm.org/D152545



More information about the llvm-commits mailing list