[llvm] [unittests] Add missing includes (PR #65681)

Zero Omega via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 15:33:04 PDT 2023


https://github.com/zeroomega updated https://github.com/llvm/llvm-project/pull/65681:

>From 3db1cc129de264cb3a47a2e81adbe70136fcbe67 Mon Sep 17 00:00:00 2001
From: Haowei Wu <haowei at google.com>
Date: Thu, 7 Sep 2023 14:36:12 -0700
Subject: [PATCH 1/2] [unittests] Add missing includes

There are missing include and using in TextStubTests and
AsmPrinterDwarfTest and they causes build failures when using vanilla
GoogleTest v1.14.0. This patch fixes this issue.
---
 llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp | 1 +
 llvm/unittests/TextAPI/TextStubHelpers.h       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
index b900e34fdd634d0..b27ff403fb1c62e 100644
--- a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
+++ b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
@@ -22,6 +22,7 @@ using namespace llvm;
 using testing::_;
 using testing::InSequence;
 using testing::SaveArg;
+using testing::DoAll;
 
 namespace {
 
diff --git a/llvm/unittests/TextAPI/TextStubHelpers.h b/llvm/unittests/TextAPI/TextStubHelpers.h
index f3303da3b951b09..f8409b10912c34b 100644
--- a/llvm/unittests/TextAPI/TextStubHelpers.h
+++ b/llvm/unittests/TextAPI/TextStubHelpers.h
@@ -6,6 +6,7 @@
 //
 //===-----------------------------------------------------------------------===/
 
+#include "llvm/ADT/SmallString.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/TextAPI/InterfaceFile.h"
 #include <algorithm>

>From f15ab23dba5e0524cf54d184e7e9dbe0fd31e79b Mon Sep 17 00:00:00 2001
From: Haowei Wu <haowei at google.com>
Date: Thu, 7 Sep 2023 15:29:27 -0700
Subject: [PATCH 2/2] amend! [unittests] Add missing includes

[unittests] Add missing includes

There are missing include and using in TextStubTests and
AsmPrinterDwarfTest and they causes build failures when using vanilla
GoogleTest v1.14.0. This patch fixes this issue.
---
 llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
index b27ff403fb1c62e..32319f1e97587f2 100644
--- a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
+++ b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
@@ -20,9 +20,9 @@
 
 using namespace llvm;
 using testing::_;
+using testing::DoAll;
 using testing::InSequence;
 using testing::SaveArg;
-using testing::DoAll;
 
 namespace {
 



More information about the llvm-commits mailing list