[PATCH] D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B

Huihui Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 13:41:50 PDT 2023


huihuiz added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:3668
+
+    if (Instruction *Result = TryXorOpt(Op0, Op1); Result != nullptr)
+      return Result;
----------------
Remove "; Result != nullptr". Not needed.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:3670
+      return Result;
+    if (Instruction *Result = TryXorOpt(Op1, Op0); Result != nullptr)
+      return Result;
----------------
Same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159380/new/

https://reviews.llvm.org/D159380



More information about the llvm-commits mailing list