[PATCH] D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR

Arcadiy Ivanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 13:25:41 PDT 2023


arcivanov added a comment.

In D126122#4640836 <https://reviews.llvm.org/D126122#4640836>, @ldionne wrote:

> I'm coming back to this in the context of the Github PR transition cleanup.
>
> Is there a reason why you're not setting `CMAKE_INSTALL_RPATH` when building your runtimes instead? I am still trying to wrap my head around the actual issue reported in https://github.com/llvm/llvm-project/issues/54955.

I'm not building "runtimes". I'm building a two-stage llvm with runtimes with LLVM build relying on the runtimes for stage2 build.

https://github.com/karellen/karellen-llvm/blob/master/patches/001-runpath.patch
https://github.com/karellen/karellen-llvm/blob/master/build-twostage.sh#L68

If you go through the history of this patchset, you'll see it's exclusively my issue but other types of builds as well.
I'm also quite exasperated dealing with this and as you can see I and other people moved to our own patches to deal with this problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126122/new/

https://reviews.llvm.org/D126122



More information about the llvm-commits mailing list