[PATCH] D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support

Michal Paszkowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 12:09:04 PDT 2023


mpaszkowski added a comment.

In D156049#4636408 <https://reviews.llvm.org/D156049#4636408>, @iliya-diyachkov wrote:

> Sorry for delay with the answer. It looks good in general.
>
> Some tests look deleted and some look newly created, but they are just moved/renamed with many changes inside. Can we split these operations? I.e. make changes related to opaque pointers and builtin types in this patch and rename the tests in a separate patch. It will save the history of changes in the tests.

Sure, I have made this patch a bit smaller. Still all the fixes are present, but I have kept all the LIT names the same and kept them in the same directories. Renaming, moving, and merging of tests will come in a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156049/new/

https://reviews.llvm.org/D156049



More information about the llvm-commits mailing list