[PATCH] D155617: Pass to annotate functions with appropriate optimization level.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Transforms/ForcedFunctionAttrs/FunctionAnnotation.csv:1
+FunctionName,OptimizationLevel
+first_function,opt-level=O1
----------------
mtrofin wrote:
> Puneeth-A-R wrote:
> > aeubanks wrote:
> > > remove?
> > @mtrofin? We had decided upon having the header, should I go ahead & remove it?
> I'm ambivalent, I kind of like it's there because it's easy to read (in the test, esp.), but if @aeubanks really wants it out, it's also easy to remove.
this patch isn't specific to optimization levels anymore, so I don't see the point in keeping it. and it'll break if we start checking that function names here are actually in the IR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155617/new/

https://reviews.llvm.org/D155617