[llvm] dc7aa0a - Revert "[lit] Fix c981c533055e's remaining test fails under windows"
Joel E. Denny via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 7 09:37:00 PDT 2023
Author: Joel E. Denny
Date: 2023-09-07T12:35:55-04:00
New Revision: dc7aa0a143fe177508ada7f065d1d6bb48e92c34
URL: https://github.com/llvm/llvm-project/commit/dc7aa0a143fe177508ada7f065d1d6bb48e92c34
DIFF: https://github.com/llvm/llvm-project/commit/dc7aa0a143fe177508ada7f065d1d6bb48e92c34.diff
LOG: Revert "[lit] Fix c981c533055e's remaining test fails under windows"
This reverts commit 012d844fb856a89368aca95ca994726554b90f22.
The reason for the revert is discussed at:
https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839/52
Added:
Modified:
llvm/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg
llvm/utils/lit/tests/shtest-output-printing.py
llvm/utils/lit/tests/shtest-shell.py
Removed:
################################################################################
diff --git a/llvm/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg b/llvm/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg
index 141fc3a596e77a6..c53fd157b6ae2df 100644
--- a/llvm/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg
+++ b/llvm/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg
@@ -2,5 +2,5 @@ import lit.formats
config.name = "shtest-output-printing"
config.suffixes = [".txt"]
-config.substitutions.append(("%{python}", f'"{sys.executable}"'))
+config.substitutions.append(("%{python}", sys.executable))
config.test_format = lit.formats.ShTest(execute_external=False)
diff --git a/llvm/utils/lit/tests/shtest-output-printing.py b/llvm/utils/lit/tests/shtest-output-printing.py
index 3e49197520a9770..427ce8f235dd055 100644
--- a/llvm/utils/lit/tests/shtest-output-printing.py
+++ b/llvm/utils/lit/tests/shtest-output-printing.py
@@ -8,7 +8,7 @@
# CHECK: -- Testing: {{.*}}
# CHECK: FAIL: shtest-output-printing :: basic.txt {{.*}}
# CHECK-NEXT: ***{{\**}} TEST 'shtest-output-printing :: basic.txt' FAILED ***{{\**}}
-# CHECK-NEXT: Exit Code: 1
+# CHECK-NEXT: Exit Code: {{[1-9][0-9]*}}
# CHECK-EMPTY:
# CHECK-NEXT: Command Output (stdout):
# CHECK-NEXT: --
diff --git a/llvm/utils/lit/tests/shtest-shell.py b/llvm/utils/lit/tests/shtest-shell.py
index a957fdda7b3c49f..97d946643b39fec 100644
--- a/llvm/utils/lit/tests/shtest-shell.py
+++ b/llvm/utils/lit/tests/shtest-shell.py
@@ -475,7 +475,7 @@
# CHECK-NEXT: # executed command: true
# CHECK:
diff -U0 {{.*}}.foo {{.*}}.bar && false || true
-# CHECK-NEXT: # executed command:
diff -U0 {{.+}}.foo{{.*}} {{.+}}.bar{{.*}}
+# CHECK-NEXT:
diff -U0 {{.*}}.foo {{.*}}.bar
# CHECK-NEXT: # .---command stdout{{-*}}
# CHECK: # | @@ {{.*}} @@
# CHECK-NEXT: # | -6 foo
More information about the llvm-commits
mailing list