[PATCH] D152468: [NFC][DebugInfo][RemoveDIs] Use iterators over instruction pointers when using IRBuilder in various passes

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 556158.
jmorse added a comment.

clang-formatted, inline fix suggestions and rebasing. In the rebase, I've lost two hunks in code that's since been refactored (LCSSA and one of many in LoopVectorise). Either that code has been deleted and we don't have to think about it any more, or it's code that will show up in the future as causing a difference between RemoveDIs / dbg.value mode, and it'll be addressed in a follow up patch.

Not landing this patch now as it depends on the parent's addition of getStableDebugLoc. I'll strip the questioned parts of that patch out and handwave about landing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152468/new/

https://reviews.llvm.org/D152468

Files:
  llvm/include/llvm/IR/BasicBlock.h
  llvm/include/llvm/IR/IRBuilder.h
  llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h
  llvm/lib/Analysis/MemoryBuiltins.cpp
  llvm/lib/CodeGen/CodeGenPrepare.cpp
  llvm/lib/CodeGen/ExpandMemCmp.cpp
  llvm/lib/CodeGen/WasmEHPrepare.cpp
  llvm/lib/IR/BasicBlock.cpp
  llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp
  llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
  llvm/lib/Target/ARM/MVETailPredication.cpp
  llvm/lib/Target/Hexagon/HexagonVectorLoopCarriedReuse.cpp
  llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
  llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp
  llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
  llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
  llvm/lib/Transforms/Scalar/LoopBoundSplit.cpp
  llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
  llvm/lib/Transforms/Scalar/SROA.cpp
  llvm/lib/Transforms/Utils/CallPromotionUtils.cpp
  llvm/lib/Transforms/Utils/InlineFunction.cpp
  llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp
  llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152468.556158.patch
Type: text/x-patch
Size: 39306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230907/6bd73d5c/attachment.bin>