[PATCH] D159478: [VP] IR expansion for inttoptr/ptrtoint

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 06:07:52 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/expand-vp-cast-intrinsics.ll:5
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2     | FileCheck %s --check-prefixes=AVX,AVX2
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vl | FileCheck %s --check-prefixes=AVX,AVX512
+
----------------
Miss_Grape wrote:
> RKSimon wrote:
> > Do we need 32-bit coverage as well?
> > ```
> > ; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avx      | FileCheck %s --check-prefixes=X86
> > ```
> How about the test with ’-mtriple=i686-unknown-unknown‘
Sure a base level i686 test would be useful to show scalarization, but itd be useful to see a vector case as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159478/new/

https://reviews.llvm.org/D159478



More information about the llvm-commits mailing list