[PATCH] D149759: [symbolizer] Support symbol lookup

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

There look like there are a few of my previous comments that haven't been addressed yet?



================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-json-code.test:65
+
+## When a module offset is specified by a symbol, more than one source locations can be found.
+# RUN: llvm-symbolizer --output-style=JSON --no-inlines -e %p/Inputs/symbols.so "static_func" | \
----------------



================
Comment at: llvm/test/tools/llvm-symbolizer/symbol-search.test:12
+
+# Check if a symbol name can be specified in command line.
+RUN: llvm-addr2line -e %p/Inputs/symbols.so func_01 | FileCheck --check-prefix=SYMB %s
----------------
You don't specify things "in" a command line, you specify them "on the command-line."


================
Comment at: llvm/test/tools/llvm-symbolizer/symbol-search.test:17
+
+# Check if a part of symbol name starting from a space is ignored.
+RUN: llvm-addr2line -e %p/Inputs/symbols.so "func_01 ignored text" | FileCheck --check-prefix=SYMB %s
----------------
I'm not sure this comment needed changing. The previous version was good: "If symbol has a space in its name, ignore everything after it." though I might change "after it" to "from the space onwards."

You could add "Check that" to the start too, so the final thing might look like:
"Check that if a symbol has a space in its name, ignore everything from the space onwards."


================
Comment at: llvm/test/tools/llvm-symbolizer/symbol-search.test:26
+
+# Check if a symbol is not found, a special mark is printed.
+RUN: llvm-addr2line --obj=%p/Inputs/symbols.so func_666 | FileCheck --check-prefix=NONEXISTENT %s
----------------
"Show that if a symbol ..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149759/new/

https://reviews.llvm.org/D149759