[PATCH] D155659: [WPD][LLD] Add option to validate RTTI is enabled on all native types and prevent devirtualization on types with native RTTI

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 21:24:56 PDT 2023


MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: lld/ELF/Driver.cpp:1073
+  // Check for unmatched RTTI symbols
+  for (auto &s : vtableSymbolsWithNoRTTI) {
+    message(
----------------
the order is not guaranteed to be deterministic. Consider a SmallSetVector with inline size=0.

`auto &` => `StringRef`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155659/new/

https://reviews.llvm.org/D155659



More information about the llvm-commits mailing list