[llvm] [NFC]Add assert to avoid possibly deref nullptr (PR #65564)

via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 20:36:31 PDT 2023


https://github.com/XinWang10 created https://github.com/llvm/llvm-project/pull/65564:

None

>From 4ef7c4c882e0413a9304f02b4a66547a0aa7c29b Mon Sep 17 00:00:00 2001
From: XinWang10 <xin10.wang at intel.com>
Date: Thu, 7 Sep 2023 11:35:34 +0800
Subject: [PATCH] [NFC]Add assert to avoid possibly deref nullptr

---
 llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp | 1 +
 llvm/lib/Target/X86/X86AsmPrinter.cpp               | 1 +
 2 files changed, 2 insertions(+)

diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
index 083d1503330a390..bb210527754d22d 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
@@ -400,6 +400,7 @@ void AsmPrinter::emitInlineAsm(const MachineInstr *MI) const {
         "Reserved registers on the clobber list may not be "
         "preserved across the asm statement, and clobbering them may "
         "lead to undefined behaviour.";
+    assert(MMI && "MMI can not be nullptr!");
     MMI->getModule()->getContext().diagnose(DiagnosticInfoInlineAsm(
         LocCookie, Msg, DiagnosticSeverity::DS_Warning));
     MMI->getModule()->getContext().diagnose(
diff --git a/llvm/lib/Target/X86/X86AsmPrinter.cpp b/llvm/lib/Target/X86/X86AsmPrinter.cpp
index bb94444525fb89a..d09732274f5c1df 100644
--- a/llvm/lib/Target/X86/X86AsmPrinter.cpp
+++ b/llvm/lib/Target/X86/X86AsmPrinter.cpp
@@ -769,6 +769,7 @@ void X86AsmPrinter::emitStartOfAsmFile(Module &M) {
       if (!TT.isArch32Bit() && !TT.isArch64Bit())
         llvm_unreachable("CFProtection used on invalid architecture!");
       MCSection *Cur = OutStreamer->getCurrentSectionOnly();
+      assert(MMI && "MMI can not be nullptr!");
       MCSection *Nt = MMI->getContext().getELFSection(
           ".note.gnu.property", ELF::SHT_NOTE, ELF::SHF_ALLOC);
       OutStreamer->switchSection(Nt);



More information about the llvm-commits mailing list