[PATCH] D159095: [lld-macho]Limit "cannot-export-hidden-symbol" warnings to only 3 to avoid crowding logs
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 6 18:33:08 PDT 2023
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: lld/MachO/Driver.cpp:1388
+ if (warningsCount > kMaxWarnings)
+ warn("<... " + Twine(warningsCount.load() - kMaxWarnings) +
+ " more similar warnings...>");
----------------
why an explicit call to `.load()` here but not in the line above? be self-consistent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159095/new/
https://reviews.llvm.org/D159095
More information about the llvm-commits
mailing list