[PATCH] D159471: [DWARFVerifier] Allow ObjectiveC names in dwarf_debug tables
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 6 15:18:51 PDT 2023
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:1366
+ // Convert to std::string first, otherwise a vector resize may
+ // destroy the StringRef memory.
+ Result.push_back(StrippedName->str());
----------------
I'm a little confused by this comment. "first" as opposed to when else?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159471/new/
https://reviews.llvm.org/D159471
More information about the llvm-commits
mailing list