[lld] a07d4c0 - [lld/ELF,gold] Remove transitionary opaque pointer flags (#65529)

[via llvm-commits]

Author: aeubanks
Date: 2023-09-06T15:07:37-07:00
New Revision: a07d4c0365ed5a34300d8c870114999dc6838c50

URL: https://github.com/llvm/llvm-project/commit/a07d4c0365ed5a34300d8c870114999dc6838c50
DIFF: https://github.com/llvm/llvm-project/commit/a07d4c0365ed5a34300d8c870114999dc6838c50.diff

LOG: [lld/ELF,gold] Remove transitionary opaque pointer flags (#65529)

This was only useful during the transition when mixing
non-opaque-pointer and opaque-pointer IR,
now everything uses opaque pointers.

Added: 
    

Modified: 
    lld/ELF/Options.td
    llvm/tools/gold/gold-plugin.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Options.td b/lld/ELF/Options.td
index 7c7664924d82897..a3adf49e3d66e10 100644
--- a/lld/ELF/Options.td
+++ b/lld/ELF/Options.td
@@ -673,8 +673,6 @@ def: J<"plugin-opt=cs-profile-path=">,
 def: J<"plugin-opt=obj-path=">,
   Alias<lto_obj_path_eq>,
   HelpText<"Alias for --lto-obj-path=">;
-def plugin_opt_opaque_pointers: F<"plugin-opt=opaque-pointers">,
-  HelpText<"Use opaque pointers in IR during LTO (default)">;
 def: J<"plugin-opt=opt-remarks-filename=">,
   Alias<opt_remarks_filename>,
   HelpText<"Alias for --opt-remarks-filename">;

diff  --git a/llvm/tools/gold/gold-plugin.cpp b/llvm/tools/gold/gold-plugin.cpp
index 59bd3f6e6686001..d43f27d9216ab07 100644
--- a/llvm/tools/gold/gold-plugin.cpp
+++ b/llvm/tools/gold/gold-plugin.cpp
@@ -308,8 +308,6 @@ namespace options {
       RemarksFormat = std::string(opt);
     } else if (opt.consume_front("stats-file=")) {
       stats_file = std::string(opt);
-    } else if (opt == "opaque-pointers") {
-      // We always use opaque pointers.
     } else {
       // Save this option to pass to the code generator.
       // ParseCommandLineOptions() expects argv[0] to be program name. Lazily