[PATCH] D158980: [DebugInfo][NFC] Move ObjC Selector name handling to lib DebugInfo
Felipe de Azevedo Piovezan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 6 13:18:32 PDT 2023
fdeazeve added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:992
+ ObjCSelectorNames Ans;
+ Ans.ClassName = ClassNameStart.take_front(FirstSpace);
+ Ans.Selector = SelectorStart.drop_back(); // drop ']';
----------------
aprantl wrote:
> maybe that's for a later patch, but this seems to be a complicated way of saying
> consumeFront("-[")
> split(" ")
Agreed. I will do a second patch after the base changes are good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158980/new/
https://reviews.llvm.org/D158980
More information about the llvm-commits
mailing list