[PATCH] D156767: [AArch64] [BranchRelaxation] Optimize for hot code size in AArch64 branch relaxation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:605
+
+      // New trampolines should be inserted after NewBB
+      TrampolineInsertionPoint = NewBB;
----------------
End complete sentences with a period.


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:608
+
+      // Retarget the unconditional branch to the trampoline block
+      BranchBB->replaceSuccessor(DestBB, NewBB);
----------------
period


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156767/new/

https://reviews.llvm.org/D156767