[PATCH] D155730: [PowerPC] Add a pass to merge all of the constant global arrays into one pool.

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp marked 4 inline comments as done.
stefanp added a comment.

In D155730#4628279 <https://reviews.llvm.org/D155730#4628279>, @lei wrote:

> For new passes, maybe we can commit it as off first and then subsequent patch to turn it on by default?  That way if it causes any issues we can just revert the default on patch.

I'm going to split this patch as you suggested. This patch will have the pass off by default and then I will add another quick patch to github where it is turned on.



================
Comment at: llvm/lib/Target/PowerPC/PPCMergeStringPool.cpp:213
+  // candidates we can skip doing the merging.
+  if (MergeableStrings.size() <= 1)
+    return false;
----------------
lei wrote:
> Wondering if maybe we need to do more investigation into this, as in is there any negative benefits to merging strings if they are < N.
I've added an option that we can use to do this investigation in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155730/new/

https://reviews.llvm.org/D155730