[PATCH] D159451: [BasicAA] BasicAA update for scalable quantity

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I'd suggest to split this into two parts: First add support for scalable LocationSize, and make sure code can handle it correctly, and then add support for scalable offsets to GEP decomposition later. I don't think the way you're currently doing it is what we want.



================
Comment at: llvm/include/llvm/Analysis/MemoryLocation.h:107
   static LocationSize precise(uint64_t Value) { return LocationSize(Value); }
   static LocationSize precise(TypeSize Value) {
     if (Value.isScalable())
----------------
precise() takes a TypeSize. You should be able to handle the isScalable() case in here only, rather than adjusting all callers to call a separate preciseScalable() method instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159451/new/

https://reviews.llvm.org/D159451