[PATCH] D158449: [IR]Add NumSrcElts param to is..Mask static function in ShuffleVectorInst.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 08:58:07 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/IR/Instructions.cpp:2350
+bool ShuffleVectorInst::isIdentityMask(ArrayRef<int> Mask, int NumSrcElts) {
+  if (Mask.size() != static_cast<unsigned>(NumSrcElts))
+    return false;
----------------
Why is the argument an int if we're going to cast it to unsigned?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158449/new/

https://reviews.llvm.org/D158449



More information about the llvm-commits mailing list