[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D155579#4636964 <https://reviews.llvm.org/D155579#4636964>, @mstorsjo wrote:

> How does this behave in your testcase @aganea?

I don't see any difference between this patch and the baseline, so that's good news.

There are two failing tests however (related to hard links):

  FAIL: LLVM-Unit :: Support/./SupportTests.exe/40/82 (5085 of 72863)
  ******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/40/82' FAILED ********************
  Script(shard):
  --
  GTEST_OUTPUT=json:C:\git\llvm-project\stage2_rpmalloc\unittests\Support\.\SupportTests.exe-LLVM-Unit-27536-40-82.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=82 GTEST_SHARD_INDEX=40 C:\git\llvm-project\stage2_rpmalloc\unittests\Support\.\SupportTests.exe
  --
  
  Script:
  --
  C:\git\llvm-project\stage2_rpmalloc\unittests\Support\.\SupportTests.exe --gtest_filter=FileSystemTest.Unique
  --
  Test Directory: C:\Users\AGANEA~1\AppData\Local\Temp\lit-tmp-_2_vvve2\file-system-test-e7decf
  C:\git\llvm-project\llvm\unittests\Support\Path.cpp(716): error: Expected equality of these values:
    D2
      Which is: 16-byte object <48-04 40-84 00-00 00-00 C6-FC EA-25 9F-15 C7-9E>
    F1
      Which is: 16-byte object <48-04 40-84 00-00 00-00 E1-BF 0D-B1 58-7A 27-07>
  
  C:\git\llvm-project\llvm\unittests\Support\Path.cpp:716
  Expected equality of these values:
    D2
      Which is: 16-byte object <48-04 40-84 00-00 00-00 C6-FC EA-25 9F-15 C7-9E>
    F1
      Which is: 16-byte object <48-04 40-84 00-00 00-00 E1-BF 0D-B1 58-7A 27-07>
  
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90
  FAIL: LLVM-Unit :: Support/./SupportTests.exe/45/82 (58768 of 72863)
  ******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/45/82' FAILED ********************
  Script(shard):
  --
  GTEST_OUTPUT=json:C:\git\llvm-project\stage2_rpmalloc\unittests\Support\.\SupportTests.exe-LLVM-Unit-27536-45-82.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=82 GTEST_SHARD_INDEX=45 C:\git\llvm-project\stage2_rpmalloc\unittests\Support\.\SupportTests.exe
  --
  
  Script:
  --
  C:\git\llvm-project\stage2_rpmalloc\unittests\Support\.\SupportTests.exe --gtest_filter=FileSystemTest.TempFiles
  --
  Test Directory: C:\Users\AGANEA~1\AppData\Local\Temp\lit-tmp-_2_vvve2\file-system-test-de39a5
  C:\git\llvm-project\llvm\unittests\Support\Path.cpp(914): error: Value of: equal
    Actual: false
  Expected: true
  C:\git\llvm-project\llvm\unittests\Support\Path.cpp(917): error: Value of: fs::equivalent(A, B)
    Actual: false
  Expected: true
  
  C:\git\llvm-project\llvm\unittests\Support\Path.cpp:914
  Value of: equal
    Actual: false
  Expected: true
  C:\git\llvm-project\llvm\unittests\Support\Path.cpp:917
  Value of: fs::equivalent(A, B)
    Actual: false
  Expected: true
  
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  ********************
  Failed Tests (2):
    LLVM-Unit :: Support/./SupportTests.exe/FileSystemTest/TempFiles
    LLVM-Unit :: Support/./SupportTests.exe/FileSystemTest/Unique
  
  
  Testing Time: 654.15s
    Skipped          :    56
    Unsupported      :  2452
    Passed           : 90408
    Expectedly Failed:   198
    Failed           :     2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579