[PATCH] D159082: [ELF][RISCV] Implement --emit-relocs with relaxation

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 00:52:34 PDT 2023


jrtc27 added a comment.

I think it's still a bit dodgy for R_RISCV_ALIGN specifically, and don't like the divergence from GNU ld -- there should really be consensus between the toolchains there -- but it may be ok.

Regarding R_RISCV_RELAX pairs that don't normally exist: nothing in the psABI says you can't do that, they just don't have a defined meaning, and in fact that's a good thing, because it means new relaxations can be defined in future and toolchains can unconditionally emit them without having to worry about whether or not the linker knows about them; old linkers will just treat them as if they didn't have R_RISCV_RELAX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159082/new/

https://reviews.llvm.org/D159082



More information about the llvm-commits mailing list