[PATCH] D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with 2 comment nits and one small test issue that should be addressed before merging.



================
Comment at: llvm/test/Object/archive-malformed-object.test:32-33
 
-## Don't emit an error if the symbol table is not required.
-# RUN: llvm-ar rcS good.a input.o input.bc
+## Don't emit an error if the symbol table is not required for gnu format.
+# RUN: llvm-ar --format=gnu rcS good.a input.o input.bc
 # RUN: llvm-ar t good.a | FileCheck %s --check-prefix=CONTENTS
----------------
Do we need to be explicit about gnu format? If the archive format is derived from the first member, this won't be big archvie, right? If we don't need to be explicit, please remove the `--format` option, so that it can capture more cases. If for whatever reason it would be bigarchive without the format option, it's fine to leave as-is.

In either case, I suggest changing the comment to say "not required for formats other than the big archive format." as it's not specifically gnu format here that's important.


================
Comment at: llvm/test/tools/llvm-ar/big-archive-xcoff-align.test:38
+
+## Test that the content of an XCOFF object files, which does not have an auxiliary
+## header, is aligned at 2 in a big archive.
----------------
Nit, missed earlier.


================
Comment at: llvm/test/tools/llvm-ar/big-archive-xcoff-align.test:68
+
+## The auxiliary header has both MaxAlignOfData and MaxAlignOfText field.
+--- !XCOFF
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144872/new/

https://reviews.llvm.org/D144872