[PATCH] D158915: [InstCombine] optimized implementations of min/max for bool

Bryan Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 15:44:47 PDT 2023


bryanpkc added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1621
+    if ((IID == Intrinsic::umin || IID == Intrinsic::smax) &&
+	    II->getType()->isIntOrIntVectorTy(1)) {
+      return BinaryOperator::CreateAnd(I0, I1);
----------------
This line is not indented correctly; please clang-format the `if` statement.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1628
+    if ((IID == Intrinsic::umax || IID == Intrinsic::smin) &&
+	    II->getType()->isIntOrIntVectorTy(1)) {
+      return BinaryOperator::CreateOr(I0, I1);
----------------
This line is not indented correctly; please clang-format the `if` statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158915/new/

https://reviews.llvm.org/D158915



More information about the llvm-commits mailing list