[PATCH] D157729: [GuardWidening] Widen widenable conditions instead of branches

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 14:03:49 PDT 2023


anna requested changes to this revision.
anna added a comment.
This revision now requires changes to proceed.

Rebase needed. thanks.



================
Comment at: llvm/lib/Transforms/Scalar/GuardWidening.cpp:292
     Instruction *InsertPt = findInsertionPointForWideCondition(ToWiden);
-    if (!mergeChecks(ChecksToHoist, ChecksToWiden, InsertPt, Result))
-      Result = hoistChecks(ChecksToHoist, InsertPt, getCondition(ToWiden));
-    if (isGuardAsWidenableBranch(ToWiden)) {
-      setWidenableBranchCond(cast<BranchInst>(ToWiden), Result);
-      return;
-    }
-    setCondition(ToWiden, Result);
+    if (mergeChecks(ChecksToHoist, ChecksToWiden, InsertPt, Result))
+      setCondition(ToWiden, Result);
----------------
Pls rebase. This was changed to return the optional result. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157729/new/

https://reviews.llvm.org/D157729



More information about the llvm-commits mailing list