[PATCH] D155995: [AMDGPU]: Allow combining into v_dot4

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12300
+}
+static unsigned addPermMasks(unsigned First, unsigned Second) {
+  unsigned FirstCs = First & 0x0c0c0c0c;
----------------
Missing newline


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12397
+
+    if (Elt->second == 0x3020100)
+      return EltVal;
----------------
maybe comment skipping bswap?


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12529
+      // add (mul24, mul24)
+      if (I == 2 && (isMul(TempNode->getOperand(AddIdx)))) {
+        Src2s.push_back(TempNode->getOperand(AddIdx));
----------------
extra parens


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155995/new/

https://reviews.llvm.org/D155995