[llvm] [libc++] Fix CODEOWNERS file for libc++ (PR #65344)

Louis Dionne via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 09:06:47 PDT 2023


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/65344:

@llvm/pr-subscribers-libcxx should not be listed as the code owner team for libcxx, since that team is only meant to control PR notifications. In the current state of things, GitHub says that I approve PRs "on behalf of pr-subscribers-libcxx", which clearly makes no sense. For example https://github.com/llvm/llvm-project/pull/65265: 
<img width="982" alt="Screenshot 2023-09-05 at 12 06 32 PM" src="https://github.com/llvm/llvm-project/assets/700834/8df67d5e-2c3f-44fc-9c2a-dfa053ea65d3">

Note that we don't have similar reviewers teams for libcxxabi and libunwind, but we should make the same change for these projects once those GH teams have been created.

CC @MaskRay 

>From 1d82d0090949b5e121b7cc54d1cbc7c729da59ef Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Tue, 5 Sep 2023 12:03:15 -0400
Subject: [PATCH] [libc++] Fix CODEOWNERS file for libc++

@llvm/pr-subscribers-libcxx should not be listed as the code owner team
for libcxx, since that team is only meant to control PR notifications.
---
 .github/CODEOWNERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 0f83e331e4537a..58a0c548e6a70e 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -290,8 +290,8 @@
 /clang/lib/CodeGen/Targets/M68k.cpp @llvm/pr-subscribers-m68k
 
 # libcxx
-/libcxx/ @llvm/pr-subscribers-libcxx
-/runtimes/ @llvm/pr-subscribers-libcxx
+/libcxx/ @llvm/reviewers-libcxx
+/runtimes/ @llvm/reviewers-libcxx
 
 # libcxxabi
 /libcxxabi/ @llvm/pr-subscribers-libcxxabi



More information about the llvm-commits mailing list