[PATCH] D151937: InstCombine: Recognize fabs as bitcasted integer

Tue Sep 5 08:33:19 PDT 2023

bjope added a comment.

In D151937#4638337 <https://reviews.llvm.org/D151937#4638337>, @arsenm wrote:

> In D151937#4638331 <https://reviews.llvm.org/D151937#4638331>, @bjope wrote:
>
>> And the fabs is lowered into a floating point instructions that would that has flushed the result to zero.
>
> Your fabs is incorrectly implemented then. fabs is defined as a non-canonicalizing bit operation. You can only use this instruction when used in a context where the result is used in a canonicalizing context

Ok. I see. Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151937/new/

https://reviews.llvm.org/D151937