[PATCH] D152534: [NFC][DebugInfo][RemoveDIs] Use moveBeforePreserving when transforms intend to move dbg.values

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 555860.
jmorse added a comment.

Add an explanatory comment as to what moveBeforePreserving is for, and the fact that it's part of the "RemoveDIs" project.

In terms of landing this, as it's an NFC change I was hoping we could just put it in as-is, it's simply changing the spelling of a function call in various places (and also reduces the rebasing / maintenance churn of our stack of patches). In terms of testing the functional changes when they arrive, it forms a part of the overall problem first suggested at D151419 <https://reviews.llvm.org/D151419>: there is no overall approach because we don't have comprehensive testing of the compiler in the first place. Once we've got a bot running RemoveDIs/DDD over the test suite transparently though, we'll have coverage over all the parts of the compiler that are currently tested at least.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152534/new/

https://reviews.llvm.org/D152534

Files:
  llvm/include/llvm/IR/Instruction.h
  llvm/lib/CodeGen/SelectOptimize.cpp
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Transforms/IPO/IROutliner.cpp
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
  llvm/lib/Transforms/Scalar/LoopInterchange.cpp
  llvm/lib/Transforms/Scalar/MergeICmps.cpp
  llvm/lib/Transforms/Scalar/SpeculativeExecution.cpp
  llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
  llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152534.555860.patch
Type: text/x-patch
Size: 7692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230905/6d4d17f0/attachment.bin>