[PATCH] D151107: [IR] Add GraalVM calling conventions
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 5 05:35:29 PDT 2023
asb added a comment.
Almost all the other added calling conventions seem to additionally add a new token so it can be named rather than using `cc $someint`. e.g. `ghccc`. Wouldn't it make sense to do the same here?
Just a few minor comments for RISC-V:
- We typically cover both rv64 and rv32 in tests. Your CHECK-NOT lines seem to be written with this in mind, but you only have an RV64 RUN line
- We normally use the minimum `-mtriple` needed to provoke the desired test output. In your case I think just `-mtriple=riscv64` would be sufficient
- We don't have RVE codegen support right now, but it would probably be sensible to report_fatal_error if Subtarget.isRVE (which has only 16 GPRs) as the calling convention clearly wouldn't be cmpatible there.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151107/new/
https://reviews.llvm.org/D151107
More information about the llvm-commits
mailing list