[PATCH] D158861: [llvm] Move CallInst::CreateMalloc to IRBuilderBase::CreateMalloc

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk added a comment.

In D158861#4637392 <https://reviews.llvm.org/D158861#4637392>, @nikic wrote:

> Would dropping the bitcast but hardcoding the "malloccall" name on the call (for now) work? As far as I can tell your current code creates a bitcast without inserting it, which would result in broken IR.

@nikic sorry for not having seen this. I still need to learn a lot about IR. I somehow thought the bitcast was inserted but I never checked. In order to keep the old behaviour for now I would have to insert the bitcast, right? And why would it be broken IR if I'd insert it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158861/new/

https://reviews.llvm.org/D158861